-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
W-15702938 Added tests for AVRO and AVRO support in async2.6 #1075
Conversation
… into W-15702938-TestsAvroDiagnostics
|
||
import scala.concurrent.ExecutionContext | ||
|
||
class Async26Test extends BasicCleanDiagnosticTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a more specific name like "Async26CleanDiagnosticTest`
import org.mulesoft.lsp.feature.diagnostic.DiagnosticSeverity | ||
|
||
|
||
class AvroSupportTest extends BasicCleanDiagnosticTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe change name to AvroCleanDiagnosticTest
?
server.shutdown() | ||
assert(d.size == 2) | ||
assert(d.head.diagnostics.length == 1) | ||
val errorMessage = d.head.diagnostics.head.message.toLowerCase() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe instead of diagnostics.head
use a find
or collect
, so we do not rely on the order of the files sent (check by uri)
} | ||
|
||
|
||
test("avro containing inline avro") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what inline avro
inside an avro means, maybe just leave this as "valid complex avro" or something?
} | ||
} | ||
|
||
test("Avro with no errors") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe "valid avro with unions"?
No description provided.